search

typeplate / typeplate.github.io

Official Website for Typeplate: “A Typographic Starter Kit.”
http://typeplate.com
Other
1.35k stars 109 forks source link

Adding/integrating a smaller scale/double strand? #113

Closed ldexterldesign closed 11 years ago

ldexterldesign commented 11 years ago

https://twitter.com/ldexterldesign/status/347352040642576384

Hey,

I need smaller numbers for my scale, so would doing this [above] - correct me if I'm wrong - be the place to extend the scale downwards? I guess the same principle would apply if you were doing double strand stuff (i.e. multiple scales)?

If so, I would have to update this piece of code in _typeplate.scss: // Multi-dimensional array, where: // the first value is the name of the class // and the second value is the variable for the size $sizes: tera $tera, giga $giga, mega $mega, alpha $alpha, beta $beta, gamma $gamma, delta $delta, epsilon $epsilon, zeta $zeta;

... which would dictate this should be located in _vars-typeplate.scss too? Remember, I don't want to have to edit _typeplate.scss itself! :P

Best regards,

ldexterldesign commented 11 years ago

https://github.com/typeplate/typeplate.github.io/issues/112

grayghostvisuals commented 11 years ago

The new vars file will help this where you can customize those default typescale variables by overriding Sass' !default flag.

ldexterldesign commented 11 years ago

Hey,

Could you point me at the new variable file or doesn't it exist yet? (I thought I was using it already, but there's no $sizes var in my version?)

Kind thanks,

grayghostvisuals commented 11 years ago

You should re-read my comment to you. https://github.com/typeplate/typeplate.github.io/issues/109#issuecomment-19431072

ldexterldesign commented 11 years ago

I'll assume you mean the last part of that comment...

... and that you're recommending I make the change myself, because it doesn't already exist ( https://github.com/typeplate/typeplate.github.io/blob/development/typeplate/scss/_vars-typeplate.scss )?

Cheers,

grayghostvisuals commented 11 years ago

Yeah the least part of my comment and yes that link you noted above. I would really hold off on any PRs atm until we can get out this next release. If you have a feature request or code suggestions file it as an issue first at this time so we can discuss it. Thanks again.

ldexterldesign commented 11 years ago

https://twitter.com/Typeplate/status/347377119086649344 ;)

Cheers,