typeplate / typeplate.github.io

Official Website for Typeplate: “A Typographic Starter Kit.”
http://typeplate.com
Other
1.35k stars 109 forks source link

libsass compilation issues - "error reading values after %" #135

Closed goosechaser closed 10 years ago

goosechaser commented 10 years ago

Hi,

Using grunt with libsass throws an error: error: error reading values after %

Offending lines 521-527 in _typeplate.scss:

html {
    @if $custom-font-family {
        font: $font-weight #{$font-size}%/#{$line-height} $custom-font-family, $font-family;
    } @else {
        font: $font-weight #{$font-size}%/#{$line-height} $font-family;
    }
}

The rest compiles well.

Cheers.

grayghostvisuals commented 10 years ago

Unfortunately, if that is the case this is a problem with libsass and not us. The entire Sass port of Typeplate compiles just fine (you can even paste the Sass file into Codepen to double check for yourself). I would suggest filing an issue with libsass instead. Thanks.

goosechaser commented 10 years ago

Dennis, it is definitely libsass's issue. However, since it's the fastest SASS compiler and one increasingly used by more and more folks, you can at least include a workaround in your docs or modify your code slightly to make it compatible with the library. Here's the ticket on their forum: https://github.com/hcatlin/libsass/issues/152#issuecomment-31325576

Thanks.

grayghostvisuals commented 10 years ago

The workaround would be a hack on my end. Sass compiler accepts this character and so should libsass. Thanks for filing the ticket though and please do let me know when they resolve a fix.

daveharrisonnet commented 10 years ago

html { Took me a few hours but the following fixes the issue when using libsass, coda plugin

@if $custom-font-family { font: $font-weight #{$font-size + "%"}/#{$line-height} $custom-font-family, $font-family; } @else { font: $font-weight #{$font-size + "%"}/#{$line-height} $font-family; } }