typeplate / typeplate.github.io

Official Website for Typeplate: “A Typographic Starter Kit.”
http://typeplate.com
Other
1.35k stars 109 forks source link

assemble: don't merge yet! #141

Closed jonschlinkert closed 10 years ago

jonschlinkert commented 10 years ago

@grayghostvisuals, please review. there is more we can probably do, but I'd love for some feedback first.

You'll notice big whitespace changes, sorry about that it's unavoidable when switching to templates. However, there are also whitespace changes in non-template-related files. Sorry about those as well, I didn't notice the editorconfig file until now. I'd be happy to reformat as tabs and do another pr if you want.

let me know what you think in general, and we can go from there.

grayghostvisuals commented 10 years ago

I ran npm install assemble and fired up my local server with our grunt-server task included in our Gruntfile.js. I'm wondering how I can preview the templates visually based on what you have so far? I believe I'm still seeing my markup that is in the root?

jonschlinkert commented 10 years ago

To rebuild the HTML files in the root, just grunt assemble before running the default task (e.g. grunt). Or just add assemble to the default task just before connect. Everything else is the same as it was before, so to view the HTML in the browser just run grunt.

grayghostvisuals commented 10 years ago

@jonschlinkert Ok so Im completely a dunce here. Finally checked it out again. Friggin' Awesome! What suggestions do you have for us so far in terms of setup or just in general that you see?

jonschlinkert commented 10 years ago

Lol, no worries. I'm not sure, let me look it over again tonight and see if I have any suggestions.

Melindrea commented 10 years ago

Looking forward to when I have a touch more time to see what you've done, considering how much I use Assemble. I'm sure to pick up some tricks that have completelly passed me by!

On 03/05/2014 12:14 AM, Jon Schlinkert wrote:

Lol, no worries. I'm not sure, let me look it over again tonight and see if I have any suggestions.

— Reply to this email directly or view it on GitHub https://github.com/typeplate/typeplate.github.io/pull/141#issuecomment-36691317.

jonschlinkert commented 10 years ago

:-) thanks @Melindrea! well, I kept things pretty basic here, so that we don't introduce a learning curve for the users, but I'm always happy to help with anything you're working on (I know @doowb is too)!

Soon though I'll be releasing the new version of the docs (hopefully days), and that project has lots of good stuff in it ;-)

grayghostvisuals commented 10 years ago

Since master changed a bit since this PR I'm gonna shift this over to the assemble branch. Thanks for setting this up @jonschlinkert. I've got a few more questions but I'll wait until it's on that branch. Thanks again for the help! :beers:

jonschlinkert commented 10 years ago

no prob, that's a good idea. still working through a couple other issues. I'll post an update in the next day or two