search

types / mysql2

Typings for https://github.com/sidorares/node-mysql2
ISC License
41 stars 23 forks source link

Missing connection options #25

Closed sleepinggenius2 closed 5 years ago

sleepinggenius2 commented 6 years ago

There seem to be some missing options on the ConnectionOptions/PoolOptions interfaces. From a quick look over the code, specifically decimalNumbers, namedPlaceholders, and nestTables. I ran into this issue in trying to use the namedPlaceholders option over the bulky queryFormat example in the documentation.

https://github.com/sidorares/node-mysql2/blob/master/lib/connection_config.js#L29,L43

sleepinggenius2 commented 6 years ago

The format, escape, and escapeId functions also seem to be missing on the Pool interface.

https://github.com/sidorares/node-mysql2/blob/master/lib/pool.js#L200,L219

lagnat commented 6 years ago

Promise is also missing.

unional commented 6 years ago

I would say PR is always welcome. 🌷

hsjoberg commented 5 years ago

authSwitcher in ConnectionOptions is also missing.

The code is just using everything from types/mysql so new properties from mysql2 is missing.

hsjoberg commented 5 years ago

I've added all missing properties in #27