search

types / mysql2

Typings for https://github.com/sidorares/node-mysql2
ISC License
41 stars 23 forks source link

Adding missing properties to ConnectionOptions #27

Closed hsjoberg closed 5 years ago

hsjoberg commented 5 years ago

This pull request adds all missing properties for the ConnectionOption interface. They are mostly new properties that didn't exist in the old mysql package.

There are some exceptions where the properties did exist in the old mysql package, but where missing from types/mysql: charsetNumber, nestTables, pool, connectionLimit, waitConnections

Also, I am uncertain on what these types should be defined as: pool, Promise and stream. These are all set as any right now.

unional commented 5 years ago

Thanks!