types / mysql2

Typings for https://github.com/sidorares/node-mysql2
ISC License
41 stars 23 forks source link

Extend FieldPacket interface #37

Closed stevenmiller888 closed 4 years ago

stevenmiller888 commented 4 years ago

It turns out that mysql and mysql2 have different property names on a column definition. The mysql library's column definition (internally called a FieldPacket) has its properties here, and the mysql2 library's column definition (internally called a ColumnDefinition) has its properties here. They differ with respect to columnType, columnLength, schema, and characterSet, so this PR extends the FieldPacket to add these types. This is a non breaking change.

unional commented 4 years ago

Thanks!