search

typesafe / mnailgun

A simple .Net wrapper library for the Mailgun API that allows you to send messages, create web hooks, manage mailboxes, etc. with minimal effort.
Other
35 stars 25 forks source link

Display Names are Ignored When Sending Mail #2

Closed robcthegeek closed 12 years ago

robcthegeek commented 12 years ago

Hey,

I came across this issue while putting together a project for a client.

I updated the display name via MailAddress("email@domain.com", "My App") - but got baffled when it didn't show up in OSX Mail.

So, I came along to check out the code (god bless open source) and came across this - we're only passing the mail address along to the API call:

new SimpleFormPart("from", mailMessage.From.Address)

Having checked the API Docs for MailGun, it seems to support 'from' display names fine - their cURL sample worked fine for me.

Any chance we can ge this updated? I will try and get a patch put together myself if I can find time!

typesafe commented 12 years ago

Hey Rob,

Can't believe I missed that :-). I'll try to update this today, if not tomorrow. If you don't beat me to it ;-).

G.

robcthegeek commented 12 years ago

No problem - easy thing to miss!

Thanks so much, will try and beat you to it - got a lot on, release looming! ;)

typesafe commented 12 years ago

Hey Rob,

Just fixed it. You can upgrade to 0.2.2 of the nuget package.

Could you let me know if it's ok?

G.

typesafe commented 12 years ago

Sorry, that would be version 0.2.3

robcthegeek commented 12 years ago

Hey Gino!

Sorry for late reply - finally got around to testing and deploying this. ALL GOOD! (in 0.2.3)

Thanks so much for the speedy turnaround, really appreciated!