search

typesafehub / akka-contrib-extra

ConductR Akka contributions
Other
9 stars 16 forks source link

Stream guardian #26

Closed huntc closed 9 years ago

huntc commented 9 years ago

A guardian actor has been introduced that will ensure a stream is closed if its parent is told to stop. Any other thread blocking on a read (for example) for the same stream should be unblocked by this action.

Fixes #24

hseeberger commented 9 years ago

It would be nice to have a test for this feature.

huntc commented 9 years ago

I was thinking that its behaviour is covered by the existing BlockingProcessSpec. You don't think so?

hseeberger commented 9 years ago

I can't find a test that tries to stop the BlockingProcess from the outside while the streams are blocking.

huntc commented 9 years ago

Fair call. I shall do that. To think I was about to go to bed... ;-)

viktorklang commented 9 years ago

A very creative solution, I like it! Please see the comments I made for improvements.

ktoso commented 9 years ago

LGTM, nice to have it wrapped up as nicely :)