WIP - DON'T MERGE: Upgrade to akka-stream/http 1.0-M5

typesafehub / akka-contrib-extra

ConductR Akka contributions

Other

9 stars 16 forks source link

WIP - DON'T MERGE: Upgrade to akka-stream/http 1.0-M5 #29

Closed hseeberger closed 9 years ago

hseeberger commented 9 years ago

ReconnectingStreamHttpSpec fails now, succeeded under M4. I wonder whether we need that feature at all, since we found an alternative approach to reconnecting for ConductR. I'd rather not include an unused feature, because unused is sort of untested.

As I'll be on vacation next week, I'll leave this one for you ...

huntc commented 9 years ago

@ktoso Can you please comment on whether we still require reconnect? I presume contrail uses it...

huntc commented 9 years ago

Whoops - merged without realising the WIP status. It did pass the PR build though...

hseeberger commented 9 years ago

Interesting! So the issue might be a timing one on my machine? As the test that fails is for an unused feature, I think we are not in trouble.

ktoso commented 9 years ago

Yes, contrail uses the reconnect from here. Only reason to pull it out was to make it usable for Heiko, which now has custom impl anyway. Happy to move it back there or replace with something else.

huntc commented 9 years ago

@ktoso I'll let you decide bearing in mind that everything in here is on its way to akka-contrib ultimately. Do you think the feature is important enough for that?