search

typesafehub / akka-contrib-extra

ConductR Akka contributions
Other
9 stars 16 forks source link

Rename args to command in BlockingProcess #4

Closed hseeberger closed 9 years ago

huntc commented 9 years ago

Deliberately named args. It is more than just the command. It is the args. :-)

huntc commented 9 years ago

If you think about Unix argv[0] is always the command for a program's main params

hseeberger commented 9 years ago

No. It is the command which is made up from the program (the first string in the list) and optional arguments. The args are just the tail of the list.

hseeberger commented 9 years ago

Also see the JavaDoc for ProcessBuilder ...

hseeberger commented 9 years ago

args is totally misleading, because it makes one think of the arguments only, leading to the question "OK, and where do I specify the program that should be executed?".

hseeberger commented 9 years ago

In RR we call it commandLine, not args or argsLine.

huntc commented 9 years ago

I was referring to Unix conventions in general, but you're right re ProcessBuilder.

hseeberger commented 9 years ago

Thanks