search

typesafehub / akka-contrib-extra

ConductR Akka contributions
Other
9 stars 16 forks source link

Upgrade to akka-streams 1.0 #43

Closed jeantil closed 9 years ago

jeantil commented 9 years ago

Upgrades the dependency and fixes renamed types

(I need this to upgrade webdriver and use Framing to close my pending isssue with it)

cheers

huntc commented 9 years ago

Thanks for doing this. I'm on vacation this week. How soon do you need the release?

jeantil commented 9 years ago

It can wait for a week. I'll use a private release in the mean time :)

Thanks for your comment !

Le ven. 26 juin 2015 23:37, Christopher Hunt notifications@github.com a écrit :

Thanks for doing this. I'm on vacation this week. How soon do you need the release?

— Reply to this email directly or view it on GitHub https://github.com/typesafehub/akka-contrib-extra/pull/43#issuecomment-115895208 .

jeantil commented 9 years ago

akka-stream 1.0 has been released I updated the commit to reflect that ...

jeantil commented 9 years ago

Indeed. I must have botched the PR somehow since that's what I have locally

jeantil commented 9 years ago

Sorry , seems like I pushed the wrong commit, the new one should be better

ktoso commented 9 years ago

LGTM, thanks!

ktoso commented 9 years ago

Realised I don't have merge rights here... weird :<

jeantil commented 9 years ago

akka-contrib-extra needs some extra love :)

huntc commented 9 years ago

Thanks for doing this. We have a dependency chain that'll be affected by this change so it'll be done in one foul swoop this week, including the merge of this.

jeantil commented 9 years ago

Ok, i'll monitor this and make the corresponding webdriver PR when the new version is released

markusjura commented 9 years ago

@jeantil Version 1.18.0 with akka streams 1.0 has been released.

jeantil commented 9 years ago

awesome ! thanks

On Fri, Jul 31, 2015 at 3:01 PM Markus Jura notifications@github.com wrote:

@jeantil https://github.com/jeantil Version 1.18.0 with akka streams 1.0 has been released.

— Reply to this email directly or view it on GitHub https://github.com/typesafehub/akka-contrib-extra/pull/43#issuecomment-126685448 .