search

typesafehub / akka-contrib-extra

ConductR Akka contributions
Other
9 stars 16 forks source link

Use out of the box Source.inputStream() and Sink.outputStream() #46

Closed fsat closed 8 years ago

fsat commented 8 years ago

This PR is created to share the progress of migrating to Akka Stream's Source.inputStream() and Sink.outputStream()

huntc commented 8 years ago

Nice

fsat commented 8 years ago

Upgrade to Akka Streams 2

fsat commented 8 years ago

Manual test done successfully on local docker and AWS.

Setup

Test Steps

  1. Start ConductR
  2. Load Elasticsearch Bundle (with prod config for AWS)
  3. Run Elasticsearch Bundle (1 instance for local & 3 instances for AWS)
  4. Load Visualizer
  5. Scale Visualizer to 3 instances
  6. Ensure all is functioning correctly - including conduct logs and conduct events
  7. Scale Visualizer to 2 instances - ensure process is terminated properly on the selected machine
  8. Scale Visualizer to 1 instance - ensure process is terminated properly on the selected machine
  9. Stop Visualizer - ensure process is terminated properly on all machine
  10. Unload Visualizer

Repeat Step 4 to 10 once more

huntc commented 8 years ago

LGTM - just a couple of small comments.

fsat commented 8 years ago

Manual test done successfully on AWS.

Setup

Test Steps

  1. Start ConductR
  2. Load Elasticsearch Bundle (with prod config for AWS)
  3. Run Elasticsearch Bundle (1 instance for local & 3 instances for AWS)
  4. Load Visualizer
  5. Scale Visualizer to 3 instances
  6. Ensure all is functioning correctly - including conduct logs and conduct events
  7. Kill visualizer process in one of the nodes, recovery should take place
  8. Scale Visualizer to 2 instances - ensure process is terminated properly on the selected machine
  9. Scale Visualizer to 1 instance - ensure process is terminated properly on the selected machine
  10. Stop Visualizer - ensure process is terminated properly on all machine
  11. Unload Visualizer

Repeat Step 4 to 11 once more

fsat commented 8 years ago

@huntc - I've fixed up the log messages too:

https://github.com/typesafehub/akka-contrib-extra/pull/46/files#diff-957773beb9b6acf2847ceacb8cd33ecbR154 https://github.com/typesafehub/akka-contrib-extra/pull/46/files#diff-957773beb9b6acf2847ceacb8cd33ecbR156 https://github.com/typesafehub/akka-contrib-extra/pull/46/files#diff-957773beb9b6acf2847ceacb8cd33ecbR159 https://github.com/typesafehub/akka-contrib-extra/pull/46/files#diff-957773beb9b6acf2847ceacb8cd33ecbR164 https://github.com/typesafehub/akka-contrib-extra/pull/46/files#diff-957773beb9b6acf2847ceacb8cd33ecbR167