search

typesafehub / akka-contrib-extra

ConductR Akka contributions
Other
9 stars 16 forks source link

[3.0] Hardening - Configure thread usage and ensure that materializers are shutdown #67

Closed longshorej closed 7 years ago

longshorej commented 7 years ago

As the title says, this configures com.zaxxer.nuprocess.threads and also ensures we're shutting down the materializers we created when we're done.

huntc commented 7 years ago

Wow, I've never read anywhere that we have to explicitly shutdown a materialiser... how did you arrive at this solution?

huntc commented 7 years ago

Ah ha - so here's why it is important to shutdown the materialiser - https://github.com/akka/akka/issues/17765

The reason that the materialiser has a system parent is because the streams can live post the process actor stopping. The changes here circumvent having a system actor in the first place. Perhaps we want to shutdown the materialiser on some timeout... or even share a materialiser?