search

typesafehub / akka-contrib-extra

ConductR Akka contributions
Other
9 stars 16 forks source link

Enhanced API and added a spec for ORMultiMap #7

Closed huntc closed 9 years ago

huntc commented 9 years ago

In addition the removeBindings api call has been removed in favour of using the newly introduced get, put and remove map level operations.

huntc commented 9 years ago

@patriknw You may like to take a peek at this also.

huntc commented 9 years ago

@hseeberger Can I get you to review noting https://github.com/typesafehub/akka-contrib-extra/pull/7#issue-51873781

huntc commented 9 years ago

@patriknw I've now hidden the implementation detail of the underlying ORSet. In addition the put function now clears out the existing set and adds the new set while retaining history. While it works I do wonder if there's a better way of doing things within put's implementation.

Additionally I've added a replaceBinding function in order to avoid the nuances of removeBinding before an addBinding.

Finally, I've added API doc and there should be good test coverage.

Review/merge at will.

patriknw commented 9 years ago

LGTM, after some minor things

huntc commented 9 years ago

Hey @patriknw - should I think about creating a PR on akka-data-replication re. ORMultiMap?

Also, when do you forsee a 1.0 for akka-data-replication? We will need something final prior to going live...

patriknw commented 9 years ago

Hey @patriknw - should I think about creating a PR on akka-data-replication re. ORMultiMap?

@huntc a PR for the MultiMap would be great.

Also, when do you forsee a 1.0 for akka-data-replication? We will need something final prior to going live...

You mean when it is incorporated in akka/akka and published in an official akka release? I have no clue apart from that it is in the plans. It should be discussed with @rkuhn.

huntc commented 9 years ago

@patriknw Just in case you don't see it: https://github.com/patriknw/akka-data-replication/pull/61