typesafehub / angular-seed-play

initial
Other
118 stars 43 forks source link

Please update to current Play version #6

Closed nob13 closed 10 years ago

nob13 commented 10 years ago

:)

huntc commented 10 years ago

Happy to accept PRs :-)

nob13 commented 10 years ago

I bumped the Play and Angular.js versions in this fork: https://github.com/nob13/angular-seed-play/tree/play221

But I cannot get the dependency to angular-routes correctly inside app.js (either it is included before angular.js or not at all). Since angular 1.2.x angular-routes has to be included separately. Any suggestions? (I am a require.js novice :/ )

huntc commented 10 years ago

Perhaps first wind back the version of Angular just to get things working.

That said... looks as though you'll need something like:

"webjars!angular-route.js"

near where the route is being used i.e.:

https://github.com/nob13/angular-seed-play/blob/master/public/js/app.js#L11

For example:

require(['angular', './controllers', './directives', './filters', './services', 'webjars!angular-route.js'],

Also why this line?

https://github.com/nob13/angular-seed-play/compare/play221#diff-fdc3abdfd754eeb24090dbd90aeec2ceR14

nob13 commented 10 years ago

Thanks alot, I got the routes dependency working. Unfortunately the webjar doesn't seem to declare the dependecy from routes to angular.js (see Bug https://github.com/webjars/angularjs/issues/30), so this is done by hand now.

The asset directory line: Oops, copied from another project, this did not worked anyway :/

jamesward commented 10 years ago

https://github.com/webjars/angularjs/issues/30 is fixed and will be released shortly.

jamesward commented 10 years ago

Resolved by #7