search

typesafehub / conductr-cli

CLI for Lightbend ConductR
Other
16 stars 21 forks source link

Name bndl component after the OCI image instead of generic "oci-image" #472

Closed longshorej closed 7 years ago

longshorej commented 7 years ago

This is a cosmetic change but I think it's nicer. Name the component after the image instead of "oci-image".

Before this Change

$ cat oldnames/elasticsearch/bundle.conf 
annotations {
  build-date = "20170406"
  license = "GPLv2"
  maintainer = "Elastic Docker Team <docker@elastic.co>"
  name = "CentOS Base Image"
  vendor = "CentOS"
  com {
    lightbend {
      conductr {
        oci-image-tags {
          oci-image = "5.4.0"
        }
      }
    }
  }
}
compatibilityVersion = "0"
diskSpace = 1073741824
memory = 402653184
name = "elasticsearch"
nrOfCpus = 0.1
roles = [
  "web"
]
system = "elasticsearch"
systemVersion = "1"
tags = [
  "5.4.0"
]
version = "1"
components {
  oci-image {
    description = ""
    file-system-type = "oci-image"
    start-command = []
    endpoints {
      oci-image-tcp-9200 {
        bind-protocol = "tcp"
        bind-port = 9200
        service-name = "oci-image-tcp-9200"
      }
      oci-image-tcp-9300 {
        bind-protocol = "tcp"
        bind-port = 9300
        service-name = "oci-image-tcp-9300"
      }
    }
  }
  bundle-status {
    description = "Status check for the bundle component"
    file-system-type = "universal"
    start-command = [
      "check"
      "--any-address"
      "$OCI_IMAGE_TCP_9200_HOST"
      "$OCI_IMAGE_TCP_9300_HOST"
    ]
    endpoints {}
  }
}-> 0

After this Change

$ cat newnames/elasticsearch/bundle.conf 
annotations {
  build-date = "20170406"
  license = "GPLv2"
  maintainer = "Elastic Docker Team <docker@elastic.co>"
  name = "CentOS Base Image"
  vendor = "CentOS"
  com {
    lightbend {
      conductr {
        oci-image-tags {
          elasticsearch = "5.4.0"
        }
      }
    }
  }
}
compatibilityVersion = "0"
diskSpace = 1073741824
memory = 402653184
name = "elasticsearch"
nrOfCpus = 0.1
roles = [
  "web"
]
system = "elasticsearch"
systemVersion = "1"
tags = [
  "5.4.0"
]
version = "1"
components {
  elasticsearch {
    description = ""
    file-system-type = "oci-image"
    start-command = []
    endpoints {
      elasticsearch-tcp-9200 {
        bind-protocol = "tcp"
        bind-port = 9200
        service-name = "elasticsearch-tcp-9200"
      }
      elasticsearch-tcp-9300 {
        bind-protocol = "tcp"
        bind-port = 9300
        service-name = "elasticsearch-tcp-9300"
      }
    }
  }
  bundle-status {
    description = "Status check for the bundle component"
    file-system-type = "universal"
    start-command = [
      "check"
      "--any-address"
      "$ELASTICSEARCH_TCP_9200_HOST"
      "$ELASTICSEARCH_TCP_9300_HOST"
    ]
    endpoints {}
  }
}-> 0