search

typesafehub / conductr-cli

CLI for Lightbend ConductR
Other
16 stars 21 forks source link

Improve resolver error reporting #478

Closed fsat closed 7 years ago

fsat commented 7 years ago

At the moment, if the bundle is not found, each resolver will return False, None, None which corresponds to something is not found (False), the file name (None), and the full path to the artefact (None).

In the event of error, at the moment False, None, None will be returned and no exception will be raised to allow for the next resolver in the chain to continue.

However I’m thinking of adding another argument which contains list of possible errors encountered during resolution.

For example, uri_resolver encounters HTTPError, it will return False, None, None, [http_error_instance], vs False, None, None, [] if the artefact is simply not found. If all is well, it will return True, file_name, file_path, [].

This way it’s possible to continue through the resolver chain, collect the possible errors that could happen, and if the bundle is indeed not found and if there are errors, we can display those.

fsat commented 7 years ago

ConductR CLI: improve error reporting during resolution process

fsat commented 7 years ago

Fixed via #485