search

typesafehub / conductr-cli

CLI for Lightbend ConductR
Other
16 stars 21 forks source link

Fix conduct load creating empty bundle configuration #524

Closed fsat closed 7 years ago

fsat commented 7 years ago

When conduct load <bundle> is invoked, empty configuration is created.

Once the expected empty bndl argument for roles is updated from None to empty array within conduct load, the empty configuration is no longer created.

fsat commented 7 years ago

Fixes #521

fsat commented 7 years ago

I will post manual test shortly.

fsat commented 7 years ago

Manual test is done successfully. Loading bundle no longer loads any config.

Start the sandbox.

Felixs-MBP-2:conductr-cli felixsatyaputra$ sandbox run 2.1.2 --no-default-features
|------------------------------------------------|
| Starting ConductR                              |
|------------------------------------------------|
Bintray credentials loaded from /Users/felixsatyaputra/.lightbend/commercial.credentials
Extracting ConductR core to /Users/felixsatyaputra/.conductr/images/core
Extracting ConductR agent to /Users/felixsatyaputra/.conductr/images/agent
Starting ConductR core instance on 192.168.10.1..
Waiting for ConductR to start..
Starting ConductR agent instance on 192.168.10.1..
|------------------------------------------------|
| OCI-in-Docker support unavailable.             |
|------------------------------------------------|
|------------------------------------------------|
| To provide support ensure Docker is running    |
| and restart the sandbox                        |
|------------------------------------------------|
|------------------------------------------------|
| Summary                                        |
|------------------------------------------------|
|- - - - - - - - - - - - - - - - - - - - - - - - |
| ConductR                                       |
|- - - - - - - - - - - - - - - - - - - - - - - - |
ConductR has been started:
  core instance on 192.168.10.1
  agent instance on 192.168.10.1
ConductR service locator has been started on:
  192.168.10.1:9008
|- - - - - - - - - - - - - - - - - - - - - - - - |
| Proxy                                          |
|- - - - - - - - - - - - - - - - - - - - - - - - |
HAProxy has not been started
To enable proxying ensure Docker is running and restart the sandbox
|- - - - - - - - - - - - - - - - - - - - - - - - |
| Bundles                                        |
|- - - - - - - - - - - - - - - - - - - - - - - - |
Check latest bundle status with:
  conduct info
Current bundle status:
Licensed To: cc64df31-ec6b-4e08-bb6b-3216721a56b@lightbend
Max ConductR agents: 10
ConductR Version(s): 0.1.0, 2.1.*
Grants: akka-sbr, cinnamon, conductr

ID  NAME  TAG  #REP  #STR  #RUN  ROLES

Warning: A newer ConductR version is available. Please upgrade the sandbox to 2.1.3 by running
Warning:   sandbox run 2.1.3

Load a bundle.

Felixs-MBP-2:conductr-cli felixsatyaputra$ conduct load continuous-delivery
Retrieving bundle..
Resolving bundle using [bintray_resolver, docker_resolver]
Loading bundle from cache typesafe/bundle/continuous-delivery
Bintray credentials loaded from /Users/felixsatyaputra/.lightbend/commercial.credentials
Retrieving from cache /Users/felixsatyaputra/.conductr/cache/bundle/continuous-delivery-2.1.0-870ee7d6a4f5853229275cca14b604b8aca62a5e74819c0a092858cc75b6c186.zip
Loading bundle to ConductR..
[##################################################] 100%
Bundle 870ee7d6a4f5853229275cca14b604b8 is installed
Bundle loaded.
Start bundle with:        conduct run 870ee7d
Unload bundle with:       conduct unload 870ee7d
Print ConductR info with: conduct info
Print bundle info with:   conduct info 870ee7d

Bundle is loaded without config.

Felixs-MBP-2:conductr-cli felixsatyaputra$ conduct info
Licensed To: cc64df31-ec6b-4e08-bb6b-3216721a56b@lightbend
Max ConductR agents: 10
ConductR Version(s): 0.1.0, 2.1.*
Grants: akka-sbr, cinnamon, conductr

ID       NAME                   TAG  #REP  #STR  #RUN  ROLES
870ee7d  continuous-delivery  2.1.0     1     0     0  continuous-delivery