search

typesafehub / conductr-lib

Other
8 stars 13 forks source link

Enable cross publishing for Scala 2.12 #119

Closed huntc closed 7 years ago

huntc commented 7 years ago

Specifically excludes projects in the cross build that do not, or indeed will not support Scala 2.12.

I'm unsure if this is totally correct, but I can + test from the root project and it will compile/test correct for both 2.11 and 2.12. We won't know if the publish/release actually works until we try it, and this PR needs to be merged before that can happen.

sbt-doge is used to solve a cross building problem within sbt.

huntc commented 7 years ago

https://github.com/typesafehub/conductr-lib/pull/119#pullrequestreview-11920054

I think it is easier to declare it across the board and then tweak it as necessary - it should be the exception rather than the rule for a sub project to have special requirements.

huntc commented 7 years ago

The CI failed because of JDK 7 being used. Unfortunately JDK 7 is no longer suitable in order to run our tests ,even though the resultant artifacts are targeted at JDK 6. The reason for this is that we've had to start using the Akka 2.4 libraries so that we can cross compile 2.12 i.e. there's a trade.

I will enable the JDK 7 based testing only for the Akka 2.3 and Play 2.3 libraries now.

huntc commented 7 years ago

Had to remove the JDK 7 runtime entirely - just won't work for us given the necessity of the Akka 2.4 tests.