search

typesafehub / conductr-lib

Other
8 stars 13 forks source link

Setup root name to s/thing other than 'root' (conductr-lib) #128

Closed ignasi35 closed 7 years ago

markusjura commented 7 years ago

@huntc This change should be a problem, right?! It means that we will not publish + release root but a conductr-lib artifacts.

huntc commented 7 years ago

@ignasi35 What's the reason for this change?

sbt root projects are generally named root by convention.

ignasi35 commented 7 years ago

Apologies for the lack of description.

The motivation for this PR is purely developer convenience. When in IntelliJ, the name of the / project (default root) is used to identify the project. Using a name other than root makes project switching easier:

screen_shot_2017-02-22_at_11_34_00
ignasi35 commented 7 years ago

I see by @markusjura this change may affect published artifacts. In that case, this PR is not a very good idea. I'll look for an alternative to achieve my intent without such a big impact.

markusjura commented 7 years ago

@ignasi35 Shall we close this PR?

ignasi35 commented 7 years ago

Thanks @markusjura for the poke. It slipped under my radar

ignasi35 commented 7 years ago

See #140