search

typesafehub / conductr-lib

Other
8 stars 13 forks source link

Ensure akka bind properties are set #144

Closed longshorej closed 7 years ago

longshorej commented 7 years ago

This PR ensures that we're setting akka.remote.netty.tcp.bind-hostname and akka.remote.netty.tcp.bind-port. We need to do this for situations where we're running inside docker containers, for instance chirper maven build via runc inside docker via Docker in OCI support.

I've manually tested this by publishing with sbt publishM2 and configuring the chirper build as necessary. Prior to this change, it would fail to start due to a failure to bind the akka remote IP.

This section of Akka documentation is relevant: http://doc.akka.io/docs/akka/current/java/remoting.html#Akka_behind_NAT_or_in_a_Docker_container

longshorej commented 7 years ago

It should be but let me run a manual test to be sure.

longshorej commented 7 years ago

Manual Test of sbt build of chirper completed without issue -- sbt-conductr was updated to use a locally published version of conductr-lib based off this branch, it was locally published, and activator-lagom-java-chirper was locally modified to use it.

This build of chirper was then deployed successfully to the sandbox.