search

typesafehub / conductr-lib

Other
8 stars 13 forks source link

Remove metricsProvider from Lagom-scala #147

Closed ignasi35 closed 7 years ago

ignasi35 commented 7 years ago

Lagom adds a metrics provider in the java DI.

This was left out in the scaladsl which required conductr-lib to step in and provided it into the cake. That was a mistake fixed in Lagom 1.3.3. So all lagom services (scala or java) already include a metricsProvider out of the box.

With the release of https://github.com/lagom/lagom/pull/637 in lagom 1.3.3 users get a compilation error because metricsProvider is mixed in twice (via lagom defaults and via conductr-lib). We can remove it from conductr-lib.

This is a multistep process involving conductr-lib and sbt-conductr repos (at least). To keep track of the evolution of this fix we have https://github.com/lagom/lagom/issues/813 with a checklist in the description.

See https://github.com/typesafehub/conductr-lib/blob/01419e01ba7471607c8a8d559e6ca2d6afaddc42/lagom1-scala-conductr-bundle-lib/src/main/scala/com/typesafe/conductr/bundlelib/lagom/scaladsl/ConductRApplicationComponents.scala#L43-L45.

ignasi35 commented 7 years ago

Unfortunately #148 was not complete. Raised #149. This issue should be reopened

ignasi35 commented 7 years ago

See #145