search

typesafehub / conductr-lib

Other
8 stars 13 forks source link

Adds missing CircuitBreakersComponents to the cake #149

Closed ignasi35 closed 7 years ago

ignasi35 commented 7 years ago

Second attempt at fixing #147. Despite publishing locally I can't retest this with sbt-conductr so I'm in the blind as much as I was on #148. :-( I tried bumping sbt-conductr dependency on conductr-lib to a localy publishd snapshot but it's not picked up. I'll try harder :-(

longshorej commented 7 years ago

Hrm - it should work with a locally published conductr-lib. I have a local branch with that same line changed to 1.9.2-SNAPSHOT and it is indeed picked up. Perhaps something is setting LagomBundleKeys.conductrBundleLibVersion and thus overwriting it?

ignasi35 commented 7 years ago

To verify this I followed the steps:

  1. rm -rf ~/.ivy2/local/com.typesafe.conductr
  2. `cd ~/git/sbt-conductr ; rm -rf target project/target``
  3. I used publishLocal to generate a 1.9.3-SNAPSHOT version of conductr-lib on my ~/.ivy2/ folder.
  4. I upgraded val conductrBundleLib = "1.9.3-SNAPSHOT" in `sbt-conductr/src/main/scala/com/lightbend/conductr/sbt/package.scala``
  5. Manually run scripted public/lagom* tests in sbt-conductr

To ensure the fix solved the issue I repeated steps 4 and 5 using "1.9.2" and that reproduced the build failure in https://travis-ci.org/typesafehub/sbt-conductr/builds/243370908