search

typesafehub / conductr-lib

Other
8 stars 13 forks source link

Config overrides break Play allowed hosts configuration #163

Closed gmethvin closed 6 years ago

gmethvin commented 6 years ago

It looks like the way conductr is configuring the Play allowed hosts prevents the user from being able to easily override them in application.conf.

See https://github.com/typesafehub/conductr-lib/blob/61897a039943650f102209c1732ff3e5e78448a5/play26-conductr-bundle-lib/src/main/scala/com/typesafe/conductr/bundlelib/play/api/Env.scala#L26

I think it would be acceptable to add hosts to the allowed hosts configuration, but not to replace them entirely.

conductr could also use play/reference-overrides.conf with:

play.filters.hosts.allowed += "127.0.0.1"
fsat commented 6 years ago

164 PR is raised to fix this issue - it's currently in progress.

longshorej commented 6 years ago

Fixed via #164