search

typesafehub / conductr-lib

Other
8 stars 13 forks source link

Provide Akka-Http support #24

Closed huntc closed 9 years ago

huntc commented 9 years ago

Extension points now provide to support the Akka apis.

This PR kicks off #23 and also updates the project to akka-http 1.0-M4.

Here's a sample of using a pure Scala approach:

       implicit val cc = ConnectionContext(system.dispatcher)

       val service = LocationService.lookup("/known")

and here is Akka/Scala:

      implicit val cc = ConnectionContext(system)

      val service = LocationService.lookup("/known")

The difference is in the establishment of the ConnectionContext. Akka requires a system whereas pure Scala just requires an ExecutionContext. The ConnectionContexts themselves are imported via com.typesafe.conductr.bundlelib.scala and com.typesafe.conductr.bundlelib.akka for Scala and Akka respectively.

2m commented 9 years ago

LGTM. Nice abstractions. Sadly I did not end up working on this today.

huntc commented 9 years ago

LGTM. Nice abstractions. Sadly I did not end up working on this today.

No problem @2m - I'll take it from here and start filling out the Play abstractions. We can chat later about what remains.

ktoso commented 9 years ago

Looks ok in general, just minor nitpicks; LGTM :)

huntc commented 9 years ago

Thanks @ktoso !

ktoso commented 9 years ago

LGTM besides some minor thingies