typesafehub / conductr-lib

Other
8 stars 13 forks source link

Configure akka remoting #32

Closed huntc closed 9 years ago

huntc commented 9 years ago

ClusterProperties.initialize() should also set up the remoting port in order for users to circumvent the need for this:

remote {
  log-remote-lifecycle-events = off
  netty.tcp {
    hostname = "127.0.0.1"
    hostname = ${?BUNDLE_HOST_IP}
    port = 8089
    port = ${?AKKA_REMOTE_HOST_PORT}
  }
}

In the same way, play-conductr-bundle-lib should also set up the remoting properties. We should similarly introduce a ClusterProperties.initialize() for Play that sets up the following properties:

http.address=$WEB_BIND_IP 
http.port=$WEB_BIND_PORT"

i.e. WEB is sought as the endpoint name to look for bind ip and port (override-able in a similar way to AKKA_REMOTE).

hseeberger commented 9 years ago

I don't think "ClusterProperties" is a good name for this extended feature, in particular for Play. Should we rename it to "TRPProperties" or something in that vein?

hseeberger commented 9 years ago

@huntc, is this what you had in mind for Akka?

huntc commented 9 years ago

Maybe just AkkaProperties and PlayProperties then?

hseeberger commented 9 years ago

OK.

huntc commented 9 years ago

Fixed by #39