search

typesafehub / conductr-lib

Other
8 stars 13 forks source link

Add enhanced AkkaProperties and fresh PlayProperties #39

Closed hseeberger closed 9 years ago

huntc commented 9 years ago

Shouldn't the host ip also be bound to?

Also, how about Play's bind ip and port?

hseeberger commented 9 years ago

Shouldn't the host ip also be bound to? -> you only mentioned "remoting port", but I'll add it Also, how about Play's bind ip and port? -> sure thing, I first wanted to get your feedback whether this goes into the right direction

hseeberger commented 9 years ago

OK, up for final review!

huntc commented 9 years ago

Lgtm. Readme and doco will require an update. Also we should now recommend calling AkkaProperties and PlayProperties init functions as good practice- before establishing the actor sys in the case of Akka.

Thanks