markusjura
commented
8 years ago The Play 2.5 conductr-bundle-lib uses the new AhcWSClient which got introduced in Play 2.5 This AhcWSClient needs a Materializer in scope. The current implementation is making use of play.api.Play.maybeApplication to get the Materializer from Play's default actor system. An IllegalStateException is thrown if no Play application is in scope.
This implementation should be changed because play.api.Play.maybeApplication has been deprecated and it makes the code harder to test because a fake application needs to be created. The new implementation of the Play 2.5 conductr-client-lib should:
- Not provide an implicit
defaultContextanymore - Provide an injectable
ConnectionContextthat uses the materializer from Play's actor system and Play's default execution context - Provide an injectable
LocationServiceandStatusServicethat uses the defaultConnectionContext
The related issue is: https://github.com/typesafehub/conductr-lib/issues/76
conductr-bundle-lib for Akka 2.4 (2.4-RC2) and Play 2.5 (2.5.0-2016-01-27-6ec2eec-SNAPSHOT).
These versions are the same versions Lagom is currently using.