The Play 2.5 conductr-bundle-lib uses the new AhcWSClient which got introduced in Play 2.5 This AhcWSClient needs a Materializer in scope. The current implementation is making use of play.api.Play.maybeApplication to get the Materializer from Play's default actor system. An IllegalStateException is thrown if no Play application is in scope.
This implementation should be changed because play.api.Play.maybeApplication has been deprecated and it makes the code harder to test because a fake application needs to be created. The new implementation of the Play 2.5 conductr-client-lib should:
Not provide an implicit defaultContext anymore
Provide an injectable ConnectionContext that uses the materializer from Play's actor system and Play's default execution context
Provide an injectable LocationService and StatusService that uses the default ConnectionContext
huntc
commented
8 years ago
The Play 2.5 conductr-bundle-lib uses the new
AhcWSClientwhich got introduced in Play 2.5 ThisAhcWSClientneeds a Materializer in scope. The current implementation is making use ofplay.api.Play.maybeApplicationto get the Materializer from Play's default actor system. AnIllegalStateExceptionis thrown if no Play application is in scope.This implementation should be changed because
play.api.Play.maybeApplicationhas been deprecated and it makes the code harder to test because a fake application needs to be created. The new implementation of the Play 2.5 conductr-client-lib should:defaultContextanymoreConnectionContextthat uses the materializer from Play's actor system and Play's default execution contextLocationServiceandStatusServicethat uses the defaultConnectionContext