search

typesafehub / conductr-lib

Other
8 stars 13 forks source link

don't use blocking on Implicits.global EC #83

Closed patriknw closed 8 years ago

patriknw commented 8 years ago

https://github.com/typesafehub/conductr-lib/blob/master/scala-common/src/main/scala/com/typesafe/conductr/lib/scala/ConnectionHandler.scala#L54

https://github.com/typesafehub/conductr-lib/blob/master/scala-conductr-bundle-lib/src/main/scala/com/typesafe/conductr/bundlelib/scala/LocationCache.scala#L43

Doing blocking things on the global EC is not acceptable.

In general blocking should be avoided on FJP, and blocking sections are risky with FJP since they may spawn almost unbounded number of threads (in Scala 2.11).

huntc commented 8 years ago

Regarding the first one, it isn't using a global EC - it is using the connection context EC which is expected to be one suitable for blocking.

Regarding the second, the global EC is just being used by a map.

I do not believe that there is an issue here...

patriknw commented 8 years ago

alright, I misread