some love for the kitty

typesafehub / ghpullrequest-validator

A simple utility to run pull requests against jenkins jobs. Uses Akka.

30 stars 9 forks source link

some love for the kitty #12

Closed adriaanm closed 11 years ago

adriaanm commented 11 years ago

update to new github api
more robust/optimistic job start detection
when job doesn't appear after a while, assume the jenkins request to start the job failed, and resend it
complete the refactoring that changed job from a String to a JenkinsJob to also use job.name where it matters
add cute sad kitty pic when build failed

review by @jsuereth

jsuereth commented 11 years ago

SO - This LGTM. I have a ton of questions, but those can be answered offline. THanks a lot for getting this thing working again. Looks like you fixed a lot of annoyances we all had and had to dig into some of the API changes pretty hard core.