typesafehub / ghpullrequest-validator

A simple utility to run pull requests against jenkins jobs. Uses Akka.
30 stars 9 forks source link

change github api for commits in pulls #14

Closed adriaanm closed 11 years ago

adriaanm commented 11 years ago

apparently github changed their api again this commit updates pullrequestcommits to return a list of PRCommits this type was formerly called CommitInfo a new class CommitInfo is introduced as the type for PRCommit's commit member

also remove unused fields to reduce our exposure to future api changes

review by @jsuereth, @dotta

dotta commented 11 years ago

LGTM!

Huge thanks Adriaan for fixing this so quickly.

viktorklang commented 11 years ago

LGTM

jsuereth commented 11 years ago

Lgtm