search

typesafehub / ghpullrequest-validator

A simple utility to run pull requests against jenkins jobs. Uses Akka.
30 stars 9 forks source link

Github API Pagination breaks comment detection #2

Open jsuereth opened 12 years ago

jsuereth commented 12 years ago

Github paginates reponse lists. Although we upped the per_page size to 11... err 100, we can't be sure that this solves the whole problem. We should update the Github API so that we can read all results rather than just the first page.

Note: Probably easiest to make some kind of buffering/blocking collection for now...

jsuereth commented 11 years ago

Note to self: @adriaanm Your fixes make this on less likely needed in the future