build every commit, use commit status to track progress

typesafehub / ghpullrequest-validator

A simple utility to run pull requests against jenkins jobs. Uses Akka.

30 stars 9 forks source link

build every commit, use commit status to track progress #20

Closed adriaanm closed 11 years ago

adriaanm commented 11 years ago

stop relying on comments & times for tracking jenkins builds
build every commit in a PR (using new jenkins jobs -- need to take a sha param)
assume we own the job when args line up, since it's building a specific commit
PLS REBUILD overrides all this logic, is taken into account only once
- track which rebuild comment/command has been taken into account using a kitty-note-to-self
still posts a comment on failure, as github only looks at last commit to determine mergeability

review by @jsuereth, /cc @lrytz, @gkossakowski, @paulp, @jamesiry

jsuereth commented 11 years ago

After I have a chance to check on this, I owe you a beer! This will make things much better. Are you testing this on Scala right now?

adriaanm commented 11 years ago

yep, it's live on my machine at home looking good so far

looking forward to :beers: :-)

lrytz commented 11 years ago

we maybe need a new army of jenkins slaves now :computer: :computer: :computer:

i'll keep an eye on it. if it's indeed a problem, maybe we can use the typesafe servers temporarily.

adriaanm commented 11 years ago

cool -- no worries, we'll be happy to get some servers :-)

lrytz commented 11 years ago

what does that mean exactly? :)

jsuereth commented 11 years ago

Wow, this looks great to me!

adriaanm commented 11 years ago

@lrytz, we're looking into setting up our own jenkins cluster and maintaining it we're not ready for that yet, but I expect it will happen before the summer