typesafehub / ghpullrequest-validator

A simple utility to run pull requests against jenkins jobs. Uses Akka.
30 stars 9 forks source link

more love for the kitten #21

Closed adriaanm closed 11 years ago

adriaanm commented 11 years ago

:cat2:

not all of the new functionality has been triggered by jobs today, but I'm pretty sure it's all net improvements

I mean, what could possibly go wronger?

review by @jsuereth

jsuereth commented 11 years ago

Again, LGTM. A minor suggestion to remove code duplication, I'll merge in the AM regardless.

jsuereth commented 11 years ago

Ok, this LGTM. Will merge now before any more build up happens!.