Don't run the validation if the PR's code can't be cleanly merged

typesafehub / ghpullrequest-validator

A simple utility to run pull requests against jenkins jobs. Uses Akka.

30 stars 9 forks source link

Don't run the validation if the PR's code can't be cleanly merged #26

Open dotta opened 11 years ago

dotta commented 11 years ago

Example, https://github.com/scala-ide/scala-ide/pull/309#issuecomment-13732750

I believe this is a regression, as this didn't use to happen in the past.

adriaanm commented 11 years ago

for the record, this depends on what your jenkins job does -- if it merges before running validation, you'll get a failure immediately when the merge fails and validation won't be run

adriaanm commented 11 years ago

(for some defintion of validation)