typesafehub / ghpullrequest-validator

A simple utility to run pull requests against jenkins jobs. Uses Akka.
30 stars 9 forks source link

better commit status reordering #27

Closed adriaanm closed 11 years ago

adriaanm commented 11 years ago

We want to ensure that a PR is only shown as ok on github if all commits and all jobs are actually ok.

Unfortunately, GitHub only looks at the most recent status of the last commit of the PR to determine the status of the whole PR.

As we can only prepend new statuses to a commit while having to support multiple jobs per commit and multiple commits per PR, we implement the following strategy to implement the desired behaviour.

adriaanm commented 11 years ago

review by @jsuereth

jsuereth commented 11 years ago

LGTM