typesafehub / ghpullrequest-validator

A simple utility to run pull requests against jenkins jobs. Uses Akka.
30 stars 9 forks source link

deal with old-style jenkins jobs, randomize timing for commit status, normalize shas #33

Closed adriaanm closed 11 years ago

adriaanm commented 11 years ago

based on feedback by @bantonsson and @dragos, therefore, review by said feedbackers

adriaanm commented 11 years ago

oh, it's already deployed in production :-) (the old jar is still there with an -old suffix)

adriaanm commented 11 years ago

it'd be great to run the kitten on itself and deploy automatically from master on PRs being merged

bantonsson commented 11 years ago

LGTM

jsuereth commented 11 years ago

Does the kitteh have tests yet?

dragos commented 11 years ago

LGTM

adriaanm commented 11 years ago

FYI, I snuck in two more commits after the LGTMs. I promise they are benign

bantonsson commented 11 years ago

LGTM