typesafehub / js-engine

A JavaScript Engine Library - provides an abstract of a means to execute JavaScript code where no browser is involved.
Other
72 stars 20 forks source link

Fixed Rhino engine implementation #22

Closed tgambet closed 10 years ago

tgambet commented 10 years ago

This pull request fixes several issues with the current Rhino engine implementation (#20, #21). It also includes a workaround for executing Trireme on Windows though it is included mainly because I don't how to take that commit out of this PR... I don't think it hurts though, and could be reverted once Trireme is fixed.

tgambet commented 10 years ago

Closing this PR

huntc commented 10 years ago

How come you closed it?

tgambet commented 10 years ago

I closed this one because it included a fix for Trireme which didn't have anything to do with Rhino (and wasn't really fixing much).