Changed Rhino implementation to evaluate scripts in a context instead of...

typesafehub / js-engine

A JavaScript Engine Library - provides an abstract of a means to execute JavaScript code where no browser is involved.

Other

72 stars 20 forks source link

Changed Rhino implementation to evaluate scripts in a context instead of... #23

Closed tgambet closed 10 years ago

tgambet commented 10 years ago

... the Rhino shell (which scope is mutated on each eval call!). RhinoShell has been renamed to RhinoExecutor as a result. Also fixed exception catching with Rhino engine (there was no test for this) and improved RhinoSpec to test for CommonJS support.

Fixes #20 and #21.

(I signed the Typesafe CLA)

huntc commented 10 years ago

Nice work! Just a few small comments.

huntc commented 10 years ago

Excellent! Thanks. One last request: can you please squash your commits?

huntc commented 10 years ago

Thanks!