search

typesafehub / js-engine

A JavaScript Engine Library - provides an abstract of a means to execute JavaScript code where no browser is involved.
Other
72 stars 20 forks source link

Increased IO timeouts for JVM engines to the maximum the scheduler will allow #28

Closed jroper closed 10 years ago

huntc commented 10 years ago

Hey James, I'd prefer that stdioTimeout is passed in as a ctor param and that the props method has a default param value of 365.days.

jroper commented 10 years ago

@huntc Making it configurable is a different (binary compatibility breaking) change.

jroper commented 10 years ago

Also, one year doesn't work, the scheduler balks saying it's too far in the future. So I've changed it so that it's no longer an arbitrary number.

huntc commented 10 years ago

Can we make it a 1.1 release? If not then we can accept this change, make a 1.0.1, apply the timeout as a param and then make a 1.1. WDYT?

jroper commented 10 years ago

If we make it a 1.1 release, then Play 2.3 can't upgrade to it.

pvlugter commented 10 years ago

For making it configurable, can that just be done via the actor system config? Then it can also be set via system property.