search

typesafehub / js-engine

A JavaScript Engine Library - provides an abstract of a means to execute JavaScript code where no browser is involved.
Other
72 stars 20 forks source link

Rename JavaxEngine to just Javax? #34

Closed benmccann closed 9 years ago

benmccann commented 9 years ago

None of the other engines have the word engine in the name, so perhaps we want to remove it from JavaxEngine to make them analagous?

huntc commented 9 years ago

The problem is that javax refers to many things, and can indeed refer to Rhino or Nashorn depending on the version of the JDK. I think it may be relevant here. WDYT?

benmccann commented 9 years ago

I don't have any strong opinion. As long as it was done on purpose. I just wanted to make sure to raise the issue since I believe the javax one was community contributed and perhaps it just slipped by code review

huntc commented 9 years ago

Thanks Ben.