search

typesafehub / js-engine

A JavaScript Engine Library - provides an abstract of a means to execute JavaScript code where no browser is involved.
Other
72 stars 20 forks source link

Build upgrades, cleanups & switch to slf4j-api. #45

Closed dwijnand closed 8 years ago

dwijnand commented 8 years ago

Fixes #44

dwijnand commented 8 years ago

Uh... has anyone this test error before? Any idea what's wrong?

dwijnand commented 8 years ago

Ok finally got Travis to pass.. required skipping a Trireme test.. Ready for review.

benmccann commented 8 years ago

lgtm other than skipping the trireme test

dwijnand commented 8 years ago

Travis failed on the thread leak test.

jroper commented 8 years ago

Hmm... does fail locally for you?

dwijnand commented 8 years ago

No

> +test
[info] Setting version to 2.10.4
[info] Reapplying settings...
[info] Set current project to jse (in build file:/Users/dnw/dev/js-engine/)
[info] RhinoSpec
[info]
[info] The Rhino engine should
[info]   + execute some javascript by passing in a string arg and comparing its return value
[info]   + execute some javascript by passing in a string arg and comparing its return value expecting an error
[info]
[info] Total for specification RhinoSpec
[info] Finished in 503 ms
[info] 2 examples, 0 failure, 0 error
[info]
[info] JavaxEngineSpec
[info]
[info] A JavaxEngine should
[info]   + execute some javascript by passing in a string arg and comparing its return value
[info]   + execute some javascript by passing in a string arg and comparing its return value expecting an error
[info]
[info] Total for specification JavaxEngineSpec
[info] Finished in 712 ms
[info] 2 examples, 0 failure, 0 error
[info]
[info] TriremeSpec
[info]
[info] The Trireme engine should
[info]   + execute some javascript by passing in a string arg and comparing its return value
[info]   + execute some javascript by passing in a string arg and comparing its return value expecting an error
[info]   + not leak threads
[info]   + not leak file descriptors
[info]
[info] Total for specification TriremeSpec
[info] Finished in 360 ms
[info] 4 examples, 0 failure, 0 error
[info]
[info] Passed: Total 8, Failed 0, Errors 0, Passed 8
[success] Total time: 3 s, completed 26-Jan-2016 23:48:04
[info] Setting version to 2.11.5
[info] Reapplying settings...
[info] Set current project to jse (in build file:/Users/dnw/dev/js-engine/)
[info] RhinoSpec
[info]
[info] The Rhino engine should
[info]   + execute some javascript by passing in a string arg and comparing its return value
[info]   + execute some javascript by passing in a string arg and comparing its return value expecting an error
[info]
[info] Total for specification RhinoSpec
[info] Finished in 509 ms
[info] 2 examples, 0 failure, 0 error
[info]
[info] JavaxEngineSpec
[info]
[info] A JavaxEngine should
[info]   + execute some javascript by passing in a string arg and comparing its return value
[info]   + execute some javascript by passing in a string arg and comparing its return value expecting an error
[info]
[info] Total for specification JavaxEngineSpec
[info] Finished in 653 ms
[info] 2 examples, 0 failure, 0 error
[info]
[info] TriremeSpec
[info]
[info] The Trireme engine should
[info]   + execute some javascript by passing in a string arg and comparing its return value
[info]   + execute some javascript by passing in a string arg and comparing its return value expecting an error
[info]   + not leak threads
[info]   + not leak file descriptors
[info]
[info] Total for specification TriremeSpec
[info] Finished in 397 ms
[info] 4 examples, 0 failure, 0 error
[info]
[info] Passed: Total 8, Failed 0, Errors 0, Passed 8
[success] Total time: 3 s, completed 26-Jan-2016 23:48:07
[info] Setting version to 2.10.4
[info] Reapplying settings...
[info] Set current project to jse (in build file:/Users/dnw/dev/js-engine/)
> eval "git show".!!
[info] ans: String = commit 84cfa8b43647234dfc7bad864abbc56aa63f623e
[info] Author: Dale Wijnand <dale.wijnand@gmail.com>
[info] Date:   Fri Dec 18 15:33:34 2015 +0000
[info]
[info]     Switch to slf4j-api. Fixes typesafehub/js-engine#44
[info]
[info] diff --git a/build.sbt b/build.sbt
[info] index 93c3238..07f8e26 100755
[info] --- a/build.sbt
[info] +++ b/build.sbt
[info] @@ -10,7 +10,8 @@ libraryDependencies ++= Seq(
[info]    "io.apigee.trireme" % "trireme-core" % "0.8.5",
[info]    "io.apigee.trireme" % "trireme-node10src" % "0.8.5",
[info]    "io.spray" %% "spray-json" % "1.3.2",
[info] -  "org.slf4j" % "slf4j-simple" % "1.7.12",
[info] +  "org.slf4j" % "slf4j-api" % "1.7.12",
[info] +  "org.slf4j" % "slf4j-simple" % "1.7.12" % "test",
[info]    "org.specs2" %% "specs2-core" % "3.6" % "test",
[info]    "junit" % "junit" % "4.12" % "test",
[info]    "com.typesafe.akka" %% "akka-testkit" % "2.3.11" % "test"
dwijnand commented 8 years ago

I mean no...

mckinley-olsen-oc commented 7 years ago

Was there some offline discussion concerning the failing test?