search

typesafehub / sbt-conductr

Typesafe ConductR plugin for sbt
Other
29 stars 22 forks source link

Addresses global scope #100

Closed huntc closed 9 years ago

huntc commented 9 years ago

As there is just one ConductR running in the background the scope of most settings should be global.

Input parsing has also been tidied up.

Also upgraded the plugin's dependencies to the latest versions including akka-http.

Fixes #99 Fixes #98

huntc commented 9 years ago

@markusjura Could you please review?

markusjura commented 9 years ago

I've tested it with https://github.com/typesafehub/conductr-service-lookup master branch. Based on the current build.sbt the following commands does not work as expected from root level:

The expectation of issue #99 is that all conduct commands can be executed from the root level. That it currently doesn't work with conductr-service-lookup is certainly related to the wrong build.sbt settings. However, we should change conductr-service-lookup alongside with this PR to reflect the issue #99.

Detailed error description and test steps

conduct info

conduct load

conduct load / run / stop / load / unload

huntc commented 9 years ago

I think we should merge this PR perhaps as it sets up the foundation for what we should now discuss: aggregate projects. I didn't consider that. When testing against Ed's projects I wasn't aggregating them, hence not experiencing the same problems.

On 8 Sep 2015, at 4:39 am, Markus Jura notifications@github.com wrote:

I've tested it with https://github.com/typesafehub/conductr-service-lookup. Based on the current build.sbt the following commands does not work as expected from root level:

conduct info conduct load conduct run conduct stop conduct unload The expectation of issue #99 is that all conduct commands can be executed from the root level. That it currently doesn't work with conductr-service-lookup is certainly related to the wrong build.sbt settings. However, we should change conductr-service-lookup alongside with this PR to reflect the issue #99.

Detailed error description and test steps

conduct info

Issue #98 is still present on root level

$ cd conductr-service-lookup $ sbt

conduct info ID NAME #REP #STR #RUN 7b22691 charon-shop-0.1.0-SNAPSHOT 3 1 0 [trace] Stack trace suppressed: run last ferryService/:conduct for the full output. [error](ferryService/:conduct) akka.actor.InvalidActorNameException: actor name [screen] is not unique! [error] Total time: 0 s, completed Sep 7, 2015 6:22:58 PM conduct load

Bundle can't be loaded from root level. When specifying the bundle file this error message is displayed:

$ cd conductr-service-lookup $ sbt

conduct load file:/Users/mj/workspace/conductr-service-lookup/target/bundle/ferry-boat-0.1.0-SNAPSHOT-33ff416147e3de86b14ed8fa9d7b806f83e774d0ac4ccbaf30c4dcc87955f95e.zip [trace] Stack trace suppressed: run last charonShopApp/:conduct for the full output. [trace] Stack trace suppressed: run last ferryService/:conduct for the full output. error Setting bundleSystem must be defined! [error] Setting bundleRoles must be defined! [error] Setting bundleNrOfCpus must be defined! [error] Setting bundleMemory must be defined! [error] Setting bundleDiskSpace must be defined! error Setting bundleSystem must be defined! [error] Setting bundleRoles must be defined! [error] Setting bundleNrOfCpus must be defined! [error] Setting bundleMemory must be defined! [error] Setting bundleDiskSpace must be defined! [error] Total time: 1 s, completed Sep 7, 2015 6:15:18 PM conduct load / run / stop / load / unload

Multiple requests are sent to the conductr sandbox if commands are executed from root level. The number of requests equals the number of subprojects:

$ cd conductr-service-lookup $ sbt

conduct stop ch [info] Stopping all bundle ch instances ... [info] Stopping all bundle ch instances ... [info] Request for stopping has been delivered with id: 8580f5ad-c3a2-49fd-a4da-b5ce55ba8dc2 [info] Request for stopping has been delivered with id: 9e2b9a2f-5e86-42d2-ac7b-ba54106623af conduct unload ch [info] Unloading bundle ch ... [info] Unloading bundle ch ... [info] Request for unloading has been delivered with id: 85b3781c-b9ce-43fe-b968-fe2aa561122d [info] Request for unloading has been delivered with id: 496f1fe4-378c-4c32-94ec-f8b2b7b60623 — Reply to this email directly or view it on GitHub.

markusjura commented 9 years ago

Ok, let's do that.

Code LGTM.

@huntc: Can you merge and release?

markusjura commented 9 years ago

LGTM, beside the comments in the documentation.

markusjura commented 9 years ago

Conversation clarified everything. LGTM