The current error handling of docker-machine is not optimal. If the VM has not been started with docker-machine start default and the user start the sbt session then he will only see this output currently:
...
host is not running
[info] Set current project to sbt-conductr-tester (in build file:/Users/mj/workspace/sbt-conductr/sbt-conductr-tester/)
[info] Control Protocol set for http://:9005. Use 'controlServer {ip-address}' to set an alternate address.
The error message host is not running comes straight from docker machine. The user doesn't now what to do here. This PR improves the output if the VM has not been started yet with docker-machine. The new output is:
...
host is not running
[warn] Docker VM has not been started. Use 'docker-machine start default' in the terminal to start the VM and reload the sbt session.
[info] Set current project to sbt-conductr-tester (in build file:/Users/mj/workspace/sbt-conductr/sbt-conductr-tester/)
[info] Control Protocol set for http://:9005. Use 'controlServer {ip-address}' to set an alternate address.
The new warning is color coded with println instead of using state.log logger. The logger can't be used here because the method resolveDefaultHostIp is called when no state is available (e.g. in ConductR acceptance tests).
The error handling for boot2docker stays the same. If both docker-machine and boot2docker and the hostname command doesn't exist then the default ip address 127.0.0.1 is returned.
@huntc: Instead of returning 127.0.0.1 we could also throw a warning saying that docker need to be installed. This case can only occur in windows scenarios.
huntc
commented
8 years ago
The current error handling of
docker-machineis not optimal. If the VM has not been started withdocker-machine start defaultand the user start the sbt session then he will only see this output currently:The error message
host is not runningcomes straight from docker machine. The user doesn't now what to do here. This PR improves the output if the VM has not been started yet withdocker-machine. The new output is:The new warning is color coded with
printlninstead of usingstate.loglogger. The logger can't be used here because the methodresolveDefaultHostIpis called when no state is available (e.g. in ConductR acceptance tests).The error handling for
boot2dockerstays the same. If bothdocker-machineandboot2dockerand thehostnamecommand doesn't exist then the default ip address127.0.0.1is returned.@huntc: Instead of returning
127.0.0.1we could also throw a warning saying that docker need to be installed. This case can only occur in windows scenarios.@huntc: Can you do a review?