Implement Control Protocol v2

typesafehub / sbt-conductr

Typesafe ConductR plugin for sbt

Other

29 stars 22 forks source link

Implement Control Protocol v2 #122

Closed fsat closed 8 years ago

fsat commented 8 years ago

Fixes https://github.com/typesafehub/conductr/issues/925.

[x] Rename v1.1 Control Protocol to v2
[x] Present bundle.conf found within bundle zip file as part of the conduct load request as opposed to parsing the bundle.conf for fields declared within the file.
[x] Present the overlay bundle.conf if found within the configuration zip in the similar fashion

huntc commented 8 years ago

Looking good

markusjura commented 8 years ago

LGTM (Beside my comment with unzipping the bundle file).

markusjura commented 8 years ago

Nice to have additional tests here.

fsat commented 8 years ago

@markusjura - I've implemented your feedback on consolidating the unzipping of the bundle file. I have also added additional tests around the load functionality. Can you review again please?

I have squashed the commits as well, and everything is ready to merge.

cc @huntc

markusjura commented 8 years ago

LGTM

fsat commented 8 years ago

Latest change was to rename body part bundleOverlayConf to bundleConfOverlay - manual tested successfully against ConductR master branch.

fsat commented 8 years ago

Also tested successfully against ConductR 1.0 branch.