Integrate sbt-lagom-bundle

typesafehub / sbt-conductr

Typesafe ConductR plugin for sbt

Other

29 stars 22 forks source link

Integrate sbt-lagom-bundle #141

Closed markusjura closed 8 years ago

markusjura commented 8 years ago

Adds the auto plugin from sbt-lagom-bundle into sbt-conductr. This means whenever the sbt-conductr library is added then the LagomBundlePlugin is triggered for every LagomPlay project.

Note

Now sbt-conductr is adding the lagom-sbt-plugin library as a dependency. This library is now part of the classpath, also for projects that are adding sbt-conductr but are not a Lagom project.

huntc commented 8 years ago

Lgtm

Not so worried about Lagom being added - no more so than Play being added. The classpath being added to is the build classpath, and not the project's. This means extra dependencies if you're building a pure Scala/Java/Akka app, but hopefully this isn't considered a burden. The benefits of a single pluggin being added should trump that hopefully.

markusjura commented 8 years ago

Well said. Agree!