search

typesafehub / sbt-conductr

Typesafe ConductR plugin for sbt
Other
29 stars 22 forks source link

Introduces the install and generateInstallationScript commands #156

Closed huntc closed 8 years ago

huntc commented 8 years ago

A new install command is provided that conveniently installs all of the bundles and their associated configurations (If present) to the local sandbox cluster. In addition, if the project is a Lagom one then the Cassandra configuration will be generated and loaded along with Cassandra.

A new generateInstallationScript command generates an installation script that is encouraged to be copied and used as the basis of a script that can manage a collection of bundles, in particular a collection that represents a system of micro services as is the case with Lagom.

Along the way, a new waitForConductr function is provided for public usage of the ConductrBundle. It is expected that ConductR's own acceptance tests can make use of this function in place of their custom logic.

The latest conductr-libs, now available from Maven, have also been included. The Lagom library is updated for milestone 2, and so that had a ripple effect on our tests which have therefore been modified.

Lastly, this PR fixes #142 by emitting a configuration file only when some configuration settings have been provided.

dotta commented 8 years ago

lgtm - it'd be good if also @markusjura could review this PR

markusjura commented 8 years ago

Overall really great improvements and nice implementation. Well done. Just added a couple of minor comments (typos, coding conventions, naming). Nothing drastic..