typesafehub / sbt-conductr

Typesafe ConductR plugin for sbt
Other
29 stars 22 forks source link

Fix netmask setup for aliases #217

Closed longshorej closed 7 years ago

longshorej commented 7 years ago

Same thing as the other PRs, this time for sbt-conductr. Explanation from https://github.com/typesafehub/conductr-cli/pull/327

Fixes a bug with setting up address aliases. While we do want to use /24 (i.e. 255.255.255.0) for finding a network address to use, we actually always want to create the alias with a /32 (i.e. 255.255.255.255) subnet mask, as the alias itself is only interested in traffic sent directly to it. This fixes a bug on some operating systems (e.g. newer linux 4.x kernels) where network aliases respond to traffic in the same subnet -- even though it's destined for other IPs.

These changes are appropriate for MacOS as well. If other team members running MacOS could verify that your sandbox works when aliases are created with 255.255.255.255 as well, I think we're good to merge.