search

typesafehub / sbt-conductr

Typesafe ConductR plugin for sbt
Other
29 stars 22 forks source link

Remove Cassandra configuration #219

Closed markusjura closed 7 years ago

markusjura commented 7 years ago

Removes the cassandra-configuration scopes. Since PR https://github.com/typesafehub/conductr-cassandra/pull/12 it is not necessary for a Lagom project to create a custom Cassandra bundle configuration.

The install command has been changed accordingly so that it does not uses the cassandra-configuration:dist command for a Lagom project.

Note that with this change the cassandra endpoints are always declared in the services, not the ACL format. This is the current endpoint format used in the default Cassandra bundle. Prior to this change the cassandra-configuration:dist command checked the BundleKeys.enableAcls key and created the endpoints respectively. Once we change the default Cassandra bundle configuration to the ACL endpoint format, it will not support ConductR 1.x anymore.

markusjura commented 7 years ago

This PR cannot be merged as long as a new conductr-cassandra bundle has been published to Bintray that contains the PR https://github.com/typesafehub/conductr-cassandra/pull/12.

markusjura commented 7 years ago

Cassandra bundle has been published.

markusjura commented 7 years ago

Tested install command with activator-lagom-java-chirper.

markusjura commented 7 years ago

Cherry pick PR for branch 2.2.x is https://github.com/typesafehub/sbt-conductr/pull/220.